Add ability to select icon style #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial step towards supporting multiple icon styles via different directories.
Simplifies directory structure and allows for different controllers to use different stick icons.
Necessary to support different resources for different styles.
Kenney's latest high-resolution input prompts asset doesn't require the icons to be completed in an editor before use. Completing the pixel icons in this commit ensures that the pixel and high-resolution icons will provide the same out-of-box experience.
- Ensure that get_setting() uses a path that exists after refactoring. - Set ProjectSetting entry to "" because it should now only be set for custom resources, and will otherwise conflict with icon styles.
Includes some placeholders for prompt icons that are included in Kenney's pixel prompts but missing from the high-resolution version.
In order for the "Reset" button in the ProjectSettings to work correctly, the metadata for each project setting has to be set unconditionally. Only the value itself should be guarded by a has_setting() check.
Sometimes, the PromptManager node seems to be removed from the tree before the InputPrompt nodes. When this happens, the editor exits with an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, there are now three different icon styles that can be selected in the ProjectSettings:
There were some cases where Kenney's high resolution input prompts did not have an icon that was present in the original pixel prompts. In those cases, I've attempted to provide an icon in the same style.
@betalars, could you please take a look at this and let me know if the default behavior is closer to what you expected?