Introduce device capability flag and default handler for parameter broadcasting #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Josh Izaac <josh146@gmail.com>
…nsform in device.batch_transform
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #2590 +/- ##
========================================
Coverage 99.58% 99.58%
========================================
Files 245 246 +1
Lines 19724 19874 +150
========================================
+ Hits 19642 19792 +150
Misses 82 82
Continue to review full report at Codecov.
|
josh146
requested changes
May 24, 2022
There was a problem hiding this comment.
Very nice and clean PR @dwierichs! Mostly left questions, but don't forget to also (a) add this PR to the changelog, and (b) ensure the new docstring appears in the docs
|
[sc-19789] |
josh146
reviewed
May 24, 2022
…tions (#2609) * commit old changes * intermed * clean up, move broadcast dimension first * update tests that manually set ndim_params for default ops * pin protobuf<4.21.0 * improve shape coersion order * changelog formatting * broadcasted pow tests * attribute test, ControlledQubitUnitary update * test kwargs attributes * Apply suggestions from code review Co-authored-by: Josh Izaac <josh146@gmail.com> * changelog * review * remove prints * explicit attribute supports_broadcasting tests * tests disentangle * fix * PauliRot broadcasted identity compatible with TF * rename "batched" into "broadcasted" for uniform namespace * old TF version support in qubitunitary unitarity check * python3.7 support * Apply suggestions from code review Co-authored-by: Josh Izaac <josh146@gmail.com> * linebreak Co-authored-by: Josh Izaac <josh146@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR is the second one to introduce parameter broadcasting, following up on #2575.
Description of the Change:
Here we introduce the device capability flag
"supports_broadcasting"and a tape expansion functionunbroadcast_expand(abatch_transform) that expands broadcasted tapes into unbroadcasted ones. This function is then used indevice.batch_transformto expand broadcasted tapes whenever the device does not support broadcasting.Benefits:
Possible Drawbacks: