Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable explicit broadcasting for lightning #317

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Disable explicit broadcasting for lightning #317

merged 4 commits into from
Jul 26, 2022

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Jul 22, 2022

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: This explicitly disables the broadcasting pipeline in PennyLane for lightning.qubit and also lightning.gpu

Description of the Change: As above.

Benefits: Ensures backwards compatibility of Lightning devices with PennyLane.

Possible Drawbacks: Updates will be required to take advantage of broadcasting supports to improve the performance with parameter-shit and finite-shots workloads.

Related GitHub Issues: PennyLaneAI/pennylane#2590 PennyLaneAI/pennylane#2627 PennyLaneAI/pennylane#2749

@mlxd mlxd marked this pull request as ready for review July 22, 2022 21:35
@github-actions
Copy link
Contributor

Test Report (Linux, Kokkos, and Kokkos Kernels) on Ubuntu

           1 files  ±0             1 suites  ±0   1s ⏱️ ±0s
       975 tests ±0         975 ✔️ ±0  0 💤 ±0  0 ±0 
229 280 runs  ±0  229 280 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit f4d3f67. ± Comparison against base commit a95cf34.

@mlxd mlxd requested review from maliasadi and albi3ro July 22, 2022 21:53
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #317 (f4d3f67) into master (a95cf34) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #317   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files          38       38           
  Lines        3920     3920           
=======================================
  Hits         3912     3912           
  Misses          8        8           
Impacted Files Coverage Δ
pennylane_lightning/lightning_qubit.py 99.61% <ø> (ø)
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a95cf34...f4d3f67. Read the comment docs.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlxd! Happy to approve.

@mlxd mlxd requested a review from antalszava July 25, 2022 18:09
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mlxd mlxd merged commit c71a74c into master Jul 26, 2022
@mlxd mlxd deleted the bcast_disable branch July 26, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants