Fix isort config

[vincentmr]

Before submitting

Please complete the following checklist when submitting a PR:

• All new features must include a unit test.
  If you've fixed a bug or added code that should be tested, add a test to the
  tests directory!

• All new functions and code must be clearly commented and documented.
  If you do make documentation changes, make sure that the docs build and
  render correctly by running make docs.

• Ensure that the test suite passes, by running make test.

• Add a new entry to the .github/CHANGELOG.md file, summarizing the
  change, and including a link back to the PR.

• Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

---

Context:
isort produces different results across Python version and environments.

Description of the Change:
Fix isort config and use GHA for isort and black.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (21cc89f) to head (6ea98c7).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
+ Coverage   98.41%   98.71%   +0.30%     
==========================================
  Files         173      172       -1     
  Lines       25224    24317     -907     
==========================================
- Hits        24823    24004     -819     
+ Misses        401      313      -88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AmintorDusko]

Hey @vincentmr, I assume you tested it with Python 3.9 (supported by us) and observed no more changes coming from it, right? In this case, thank you very much for that. Now that we have a consistent development environment, I'm happy. I will approve, but please wait for #646 to be merged, before merging this PR.

[maliasadi]

@vincentmr What about using these custom options in pyproject.toml so that we can reuse them in our GH action. Look at what we've done in Catalyst for an example.

Let's not use 3rd-part actions in our recipes where we can simply install these packages from PyPI ;)

[vincentmr]

@vincentmr What about using these custom options in pyproject.toml so that we can reuse them in our GH action. Look at what we've done in Catalyst for an example.

Since this is only for isort at this point, I think the CLI is still doing the job.

Let's not use 3rd-part actions in our recipes where we can simply install these packages from PyPI ;)

I would agree with the exception when the action is from the package collab, as in the present case.

[rashidnhm]

Would it make sense to use make format-python within CI instead of the actions? One benefit of doing that is it would ensure we're running identical code across both CI and local development environments.

[vincentmr]

Would it make sense to use make format-python within CI instead of the actions? One benefit of doing that is it would ensure we're running identical code across both CI and local development environments.

Do you mean make format-python check=1?