Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate lightning.qubit to the new API #646

Merged
merged 290 commits into from
Mar 21, 2024
Merged

Conversation

AmintorDusko
Copy link
Contributor

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

AmintorDusko and others added 30 commits February 21, 2024 11:23
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
@AmintorDusko AmintorDusko mentioned this pull request Mar 19, 2024
5 tasks
@AmintorDusko AmintorDusko marked this pull request as ready for review March 19, 2024 19:36
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nothing to add :)

@AmintorDusko
Copy link
Contributor Author

A changelog is still needed.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🥇

@AmintorDusko
Copy link
Contributor Author

[sc-58044] [sc-59002]

@AmintorDusko AmintorDusko added the ci:build_wheels Activate wheel building. label Mar 21, 2024
@AmintorDusko AmintorDusko merged commit c82198b into master Mar 21, 2024
85 checks passed
@AmintorDusko AmintorDusko deleted the lightning-qubit-new-api branch March 21, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants