Lower overhead of Windows CI tests #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## update/lgpu_cuda12 #610 +/- ##
======================================================
- Coverage 98.48% 97.60% -0.89%
======================================================
Files 169 169
Lines 24760 24299 -461
======================================================
- Hits 24386 23717 -669
- Misses 374 582 +208 ☔ View full report in Codecov by Sentry. |
|
Note that the CUDA 12 PR is required to pass the final tests, so this will first be merged onto that. |
AmintorDusko
approved these changes
Feb 7, 2024
mlxd
changed the title
mlxd
added a commit
that referenced
this pull request
Feb 12, 2024
* Add build and test support for CUDA 12 * Auto update version * Fix name * Avoid overstepping with CUDA 11 on 12 * Fix wheel output naming * Remove unneeded strings * Add missing 0 to CUDA 11 install * Trigger CI * Update to allow CUDA 11 wheels to build also * Update fromJSON usage * Update int to str in json map * Aim to keep cuda 11.5 wheels for now * Remove CUDA 11 * Migrate windows tests to clangcl to avoid failures * Ensure VS generator used * Update for auditwheel 6.0 changes * Ensure devtoolset values are used in CUDA 12 build * Remove unneeded deref * Retry installing cuda 12.0 * Fix auditwheel arch check * Fix auditwheel arch check again * Revert windows tests * Lower overhead of Windows CI tests (#610) * Cache vcpkg libs and reuse * Auto update version * Trigger CI * Fix matrix tests for windows * Add excluded modules for OpenCPPCoverage * Convert dash to underscore * Use optimized build for Windows coverage * Retrigger CI --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> * Update changelog * Remove trainability from stateprep in test * Update dev reqs to use cu12 * Fix formatting * Update the MPI modules in CI * Add ls to module dirs * Remove additional cu11 deps * Use mpirun from PATH * Update to cu12 in missing locations * Remove opt path specifics * Ensure cuda version env vars are inlcuded on Python tests for MPI --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: The Windows test suite often takes a long time to complete, or hangs on coverage generation during tests. Improving the Windows CI test runtime will help unblock other PRs in the ecosystem, where Windows CI runners are often timing out.
Description of the Change: This PR removes system-level debug files from the OpenCPPCoverage PDB paths, caches the vcpkg generated builds, and uses a RelWithDebInfo build for the coverage tests under Windows, following support in OpeCPPCoverage.
Benefits: Unblocks the Windows CI tests of incoming PRs.
Possible Drawbacks: Time-out issue may still occur, though frequency of occurrence dropped during testing of this PR.
Related GitHub Issues: