Add build and test support for CUDA 12 #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-lightning into update/lgpu_cuda12
|
[sc-37516] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #606 +/- ##
==========================================
- Coverage 98.48% 97.06% -1.43%
==========================================
Files 169 145 -24
Lines 24760 19276 -5484
==========================================
- Hits 24386 18711 -5675
- Misses 374 565 +191 ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #606 +/- ##
==========================================
+ Coverage 98.48% 98.68% +0.19%
==========================================
Files 169 169
Lines 24760 24299 -461
==========================================
- Hits 24386 23980 -406
+ Misses 374 319 -55 ☔ View full report in Codecov by Sentry. |
* Cache vcpkg libs and reuse * Auto update version * Trigger CI * Fix matrix tests for windows * Add excluded modules for OpenCPPCoverage * Convert dash to underscore * Use optimized build for Windows coverage * Retrigger CI --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com>
mlxd
requested review from
vincentmr and
AmintorDusko
and removed request for
vincentmr
AmintorDusko
approved these changes
Feb 9, 2024
mlxd
added
the
ci:use-multi-gpu-runner
vincentmr
reviewed
Feb 9, 2024
vincentmr
approved these changes
Feb 9, 2024
|
OpenMPI 5.0 is causing failures with the distributed workload. We will need to rebuild the runner image using an older version and rerun before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: This PR adds build and test support for CUDA 12 with
lightning.gpuand sunsets CUDA 11 support in the shipped wheels.Description of the Change: Updates the build tooling to use CUDA 12
Benefits: Natively supports CUDA 12
Possible Drawbacks: Additional build overhead if CUDA 11 is maintained.
Related GitHub Issues: