-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the stopping condition method #386
Conversation
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
- Coverage 99.88% 99.88% -0.01%
==========================================
Files 49 49
Lines 4471 4469 -2
==========================================
- Hits 4466 4464 -2
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hi @AmintorDusko , Nice work! Just leave two minor comments. One general question is if there is any other benefit we can get from this refactor except what you mentioned above. |
The benefits are essentially what I already said. |
[sc-29679] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @AmintorDusko
Just 2 comments, then happy to approve
Context:
Improve the
stopping_condition
method, and expand tests to cover tape execution.Description of the Change:
stopping_condition
to rely on thesupports_operation
method.Benefits:
Operations will only be decomposed if not supported by Lightning.
Possible Drawbacks:
Related GitHub Issues: