This repository has been archived by the owner on Feb 5, 2024. It is now read-only.
Improved stopping_condition method and more performant wheel build. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I removed, for now, the workflow update_dev_version. Without the proper setting, it is guaranteed that it will always fail. |
AmintorDusko
changed the title
|
[sc-29883] |
|
[sc-29886] |
mlxd
approved these changes
Nov 23, 2022
multiphaseCFD
approved these changes
Nov 23, 2022
AmintorDusko
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: This PR optimizes the wheels build for Linux, improves the stopping_condition method for
lightning.gpu, and improve the testing.Description of the Change:
stopping_condition, relying on the supports_operation method, was implemented. [Lightning-#386]Benefits:
Faster wheel builds, more reliable
stopping_condition, and more tests in the repository.Possible Drawbacks:
Related GitHub Issues: