Divide Util.hpp and fix some bugs there #228
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
=======================================
Coverage 99.71% 99.71%
=======================================
Files 4 4
Lines 351 351
=======================================
Hits 350 350
Misses 1 1
Continue to review full report at Codecov.
|
| } else if constexpr (std::is_same_v<T, double>) { | ||
| cblas_zgemm(CblasRowMajor, CblasNoTrans, tr, m, n, k, &co, m_left, | ||
| k, m_right, transpose ? n : k, &cz, m_out, n); | ||
| } |
There was a problem hiding this comment.
FYI, the previous code was
pennylane-lightning/pennylane_lightning/src/util/Util.hpp
Lines 973 to 979 in 8b9d412
| res[i] = std::get<1>(arr[i]); | ||
| } | ||
| return res; | ||
| } |
There was a problem hiding this comment.
FYI, this function was the same as fist_elts_of previously. Besides these two functions, every other functions are the same.
chaeyeunpark
requested review from
mlxd and
maliasadi
and removed request for
mlxd
There was a problem hiding this comment.
Great job on this @chaeyeunpark
That refactor was definitely needed (and nice work on the bug fixes too!)
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: After several recent commits,
Util.hppfile becomes >1000 lines, and some hidden bugs are found. This PR (1) divides this file into smaller files and (2) fix bugs.Description of the Change: Divide
Util.hppintoLinearAlgebra.hpp,ConstantUtil.hpp, andBitUtil.hpp. Also fixes bugs insecond_elts_ofandmatrixMatProd. Also changedCMakeLists.txtandMakefile.Benefits: Slightly better compile time.
Possible Drawbacks:
Related GitHub Issues:
Closes #227