Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Util::matrixMatrixProduct produces a wrong result with BLAS #227

Closed
chaeyeunpark opened this issue Feb 8, 2022 · 0 comments · Fixed by #228
Closed

Util::matrixMatrixProduct produces a wrong result with BLAS #227

chaeyeunpark opened this issue Feb 8, 2022 · 0 comments · Fixed by #228
Labels
bug Something isn't working

Comments

@chaeyeunpark
Copy link
Contributor

chaeyeunpark commented Feb 8, 2022

Before posting an issue

Search existing GitHub issues to make sure the issue does not already exist:
https://github.com/xanaduai/pennylane-lightning/issues

If posting a PennyLane-Lightning issue, delete everything above the dashed line, and fill
in the template. If the issue is a bug, start the title of the issue with [BUG].

If making a feature request, delete the following template and describe, in detail,
the feature and why it is needed.

For general technical details check out our documentation:
https://pennylane-lightning.readthedocs.io/


Issue description

Description of the issue - include code snippets and screenshots here
if relevant. You may use the following template below

  • Expected behavior: (What you expect to happen)
    C++ tests should pass with BLAS

  • Actual behavior: (What actually happens)
    Tests fail

  • Reproduces how often: (What percentage of the time does it reproduce?)

  • System information: (post the output of import pennylane as qml; qml.about())

This is in fact caused by two convoluted problems:

  1. matrixMatProd(m_left, m_right, .., transpose=true) function in Util.hpp transpose m_right (expected behaviour) when BLAS is not used, but BLAS version transpose m_left.
  2. Currently C++ tests do not use BLAS even when -DENABLE_BLAS=ON is given as tests/CMakeLists.txt does not include external library or compile flags set by the options.

Fortunately, as wheels are built with DENABLE_BLAS=OFF, this does not cause an issue for usual users (unless someone compiles from the source directly). Still, I will fix this ASAP.

@chaeyeunpark chaeyeunpark added the bug Something isn't working label Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant