Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get cirq-core only #94

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Get cirq-core only #94

merged 1 commit into from
Mar 9, 2022

Conversation

antalszava
Copy link
Contributor

@antalszava antalszava commented Mar 9, 2022

Installing cirq pulls in packages that are not used by this plugin, but packages that bring further dependency constraints.

Pulling cirq-core only along with cirq-pasqal should provide a solution.

This is useful for the QML repository, where a dependency conflict arises between cirq-rigetti and TensorFlow:

The conflict is caused by:
    tensorflow 2.6.0 depends on six~=1.15.0
    cirq-rigetti 0.13.1 depends on six~=1.16.0

With the changes here, we'll no longer be requiring cirq-rigetti.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #94 (d36be33) into master (7515d59) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files           8        8           
  Lines         391      391           
=======================================
  Hits          388      388           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7515d59...d36be33. Read the comment docs.

@antalszava antalszava requested a review from Jaybsoni March 9, 2022 21:24
Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that the naming changed, Should we pin it to the latest (0.13.x)?

@antalszava
Copy link
Contributor Author

antalszava commented Mar 9, 2022

Interesting that the naming changed, Should we pin it to the latest (0.13.x)?

Rather than a naming change, this pulls in only Cirq core. When hitting pip install cirq multiple packages are pulled in:

Collecting cirq
  Using cached cirq-0.13.1-py3-none-any.whl (7.7 kB)
Collecting cirq-pasqal==0.13.1
  Using cached cirq_pasqal-0.13.1-py3-none-any.whl (29 kB)
Collecting cirq-aqt==0.13.1
  Using cached cirq_aqt-0.13.1-py3-none-any.whl (18 kB)
Collecting cirq-ionq==0.13.1
  Using cached cirq_ionq-0.13.1-py3-none-any.whl (47 kB)
Collecting cirq-google==0.13.1
  Using cached cirq_google-0.13.1-py3-none-any.whl (437 kB)
Collecting cirq-core==0.13.1
  Using cached cirq_core-0.13.1-py3-none-any.whl (1.6 MB)
Collecting cirq-web==0.13.1
  Using cached cirq_web-0.13.1-py3-none-any.whl (328 kB)
Collecting cirq-rigetti==0.13.1
  Using cached cirq_rigetti-0.13.1-py3-none-any.whl (55 kB)

along with further dependencies (e.g., six).

As for pinning, it's okay as is, we'd pin for 0.13.x if the plugin was not working with >=0.10.0, <0.13.0.

@antalszava antalszava merged commit 75e4923 into master Mar 9, 2022
@antalszava antalszava deleted the get_cirq_core_and_pasqal_only branch March 9, 2022 21:34
antalszava added a commit that referenced this pull request Mar 9, 2022
Jaybsoni added a commit that referenced this pull request Mar 9, 2022
* pre release version bump

* Update CHANGELOG.md

* Update pennylane_cirq/_version.py

* Update pennylane_cirq/_version.py

* Update pennylane_cirq/_version.py

* changelog for #94

* changelog

* changelog

Co-authored-by: Jaybsoni <Jaybsoni@users.noreply.github.com>
Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
Co-authored-by: antalszava <antalszava@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants