Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Bump #93

Merged
merged 9 commits into from
Mar 9, 2022
Merged

Version Bump #93

merged 9 commits into from
Mar 9, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 9, 2022

updated changelog and _version.py

@github-actions github-actions bot requested a review from rmoyard March 9, 2022 20:56
CHANGELOG.md Outdated Show resolved Hide resolved
pennylane_cirq/_version.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #93 (0c22457) into master (75e4923) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files           8        8           
  Lines         391      391           
=======================================
  Hits          388      388           
  Misses          3        3           
Impacted Files Coverage Δ
pennylane_cirq/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e4923...0c22457. Read the comment docs.

@Jaybsoni Jaybsoni requested a review from antalszava March 9, 2022 21:01
pennylane_cirq/_version.py Outdated Show resolved Hide resolved
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Jaybsoni
Copy link
Contributor

Jaybsoni commented Mar 9, 2022

💯

Looks good! Just out of curiosity, the change to the requirements isn't really user facing, do we need to include it in the changelog? I remember in the past we have had changes to the test suite for bug fixes and those were typically not included in the changelog either because they weren't adding or removing functionality?

@Jaybsoni Jaybsoni merged commit 396c397 into master Mar 9, 2022
@Jaybsoni Jaybsoni deleted the pre-release-version-bump branch March 9, 2022 22:14
@antalszava
Copy link
Contributor

Just out of curiosity, the change to the requirements isn't really user facing, do we need to include it in the changelog? I remember in the past we have had changes to the test suite for bug fixes and those were typically not included in the changelog either because they weren't adding or removing functionality?

Good point! The thing is, from this point on, whenever a user installs PennyLane-Cirq in a new environment, they will get fewer Cirq-related packages. So in that sense the change is user-facing: they might expect to get things like cirq-rigetti still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants