Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend] Program verification #626

Merged
merged 183 commits into from
Jun 13, 2024
Merged

[Frontend] Program verification #626

merged 183 commits into from
Jun 13, 2024

Conversation

sergei-mironov
Copy link
Contributor

@sergei-mironov sergei-mironov commented Mar 22, 2024 •
edited
Loading

Context: Having a proper encoding for the device capabilites, we implement the main part of program verification in this PR.

Description of the Change:
[sc-55558]
[sc-60607]
[sc-60648]

  • Verify that no MCM (measure op) is present in the call
  • Verify that no callbacks are present in the call tree (future: verify that callbacks have custom vjp or are io callbacks)
  • Verify that no state or variance is returned from the QNode. (Double check if Lightning Adjoint supports this!)
  • adjoint diff method: Does the Tape only contain operations deemed differentiable by the QJITDevice from the TOML spec?
  • parameter-shit method: Does the Tape only contain operations that support the 2-term parameter shift rule?

Benefits:

Possible Drawbacks:

Related GitHub Issues:

The following PRs need to be merged before this one:

Sergei Mironov added 30 commits March 14, 2024 10:00
Clean-up unconditional addition of the ControlledQubitUnitary to QJIT…
af40cf6 
… device gates
Clean-up unconditional addition of the ControlledQubitUnitary to QJIT…
a4bbd6b 
… device gates
Explicitly list supported controlled gates
f4ee1a8
Fix missing Projector observable in the kokkos device config
5d288e8
Read toml files in binary mode
5174342
[FIX] Apply ASAN runner_mu fix
6ef4188
Merge branch 'main' into native-quantum-control-toml-fixup
d367d12
Program verification initial commit
797fd2d
Ongoing work
54d7808
Implement device capability datastructure
fc23d2d
Implement device capability datastructure
728171e
Implement device capability datastructure
e49f521
Implement device capability datastructure
fc1fdfc
Implement device capability datastructure
649437f
Implement device capability datastructure
9d0c1c9
Implement device capability datastructure
97bfa29
Implement device capability datastructure
dd6d469
Implement device capability datastructure
f5c8d21
Clean up the code
5d15a81
Temporary revert verification draft
83b2f8a
Address CodeCov issues
96d1f81
Merge remote-tracking branch 'origin/main' into program-verification
1b51b59
Address CodeCov issues
e8cf0db
Address CodeCov issues
1cc4bf2
Address CodeCov issues
b765320
Address CodeCov issues
0668639
Address CodeCov issues
6855293
Address CodeCov issues
dbb62df
Fix kokkos tests
986e682
Merge remote-tracking branch 'origin/main' into program-verification
e47402e
lillian542 and others added 21 commits June 7, 2024 11:15
@lillian542
Iterate over measurements instead of observables
b10c7a2
@lillian542
Remove outdated comments
2dd302c
@lillian542
fix the bug I just introduced
ddca6ae
@lillian542
update controlled criteria in inv checker
1b3057c
@lillian542
Merge branch 'main' into program-verification-2
c3fe6c8
@lillian542
Merge branch 'main' into program-verification-2
a950d0f
@lillian542
actually resolve merge conflicts
8156ce3
@lillian542
update verification for new Adjoint structure
96cba56
@lillian542
Merge branch 'main' into program-verification-2
0be4df7
@lillian542
fix duplication following merge conflict
bdc14d9
@dime10
Simplify Adjoint/Control structure in Catalyst (#802)
1cc8d50 
@lillian542 My proposal would be removing the (single-op) Adjoint class
in Catalyst entirely, which would get rid of the issues we faced.
Instead, we dispatch directly to PennyLane's Adjoint when a single op is
received by Catalyst.
It does requires that `Adjoint(gate)` can be lowered directly to a
single operator in MLIR, which I've added. I also updated the
verification to match.
It also relies on the addition of a `create_adjoint_op` function to
PennyLane similar to the existing `create_controlled_op` function.

If you think this is a good direction I would update to the latest main
branch to get the QCtrl changes in, and update them similarly to what
I've done with Adjoint.

[sc-65586]
@lillian542
Merge branch 'main' into program-verification-2
d20130b
@lillian542
parameterize adj and ctrl tests over different op types
d9359cf
@lillian542
update tests for hybridctrl
75e7e89
@lillian542
add more thorough testing for nested hybrid ops verification
6a86713
@lillian542
formatting
8670733
@lillian542
fix formatting things
f7bb8c6
@lillian542
remove unrecognized mocker object
2d5a77d
@lillian542
fix import order
813e34f
@lillian542
add test for codecov
ccde863
@lillian542
add validation for pure PL nested operators
022755a
dime10
dime10 approved these changes Jun 13, 2024
View reviewed changes
frontend/catalyst/programs/verification.py Outdated Show resolved Hide resolved
frontend/catalyst/programs/verification.py Outdated Show resolved Hide resolved
@dime10 dime10 added the frontend Pull requests that update the frontend label Jun 13, 2024
@dime10 dime10 merged commit a36947d into main Jun 13, 2024
51 of 53 checks passed
@dime10 dime10 deleted the program-verification-2 branch June 13, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lillian542 lillian542 lillian542 left review comments

@mlxd mlxd mlxd left review comments

@dime10 dime10 dime10 approved these changes

Assignees
No one assigned
Labels
frontend Pull requests that update the frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sergei-mironov @lillian542 @mlxd @dime10