[Frontend] Implement quantum device capabilities as a data structure #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 14, 2024 10:00
sergei-mironov
changed the base branch from
main
to
native-quantum-control-toml-fixup
added 10 commits
March 21, 2024 13:36
sergei-mironov
changed the title
rmoyard
reviewed
Apr 16, 2024
Co-authored-by: Romain Moyard <rmoyard@gmail.com>
Co-authored-by: Romain Moyard <rmoyard@gmail.com>
rmoyard
reviewed
Apr 25, 2024
rmoyard
approved these changes
Apr 29, 2024
rmoyard
added a commit
that referenced
this pull request
May 1, 2024
dime10
added a commit
that referenced
this pull request
Jun 13, 2024
**Context:** Having a proper encoding for the device capabilites, we implement the main part of program verification in this PR. **Description of the Change:** [sc-55558] [sc-60607] [sc-60648] * [x] Verify that no MCM (measure op) is present in the call * [ ] Verify that no callbacks are present in the call tree (future: verify that callbacks have custom vjp or are io callbacks) * [x] Verify that no state or variance is returned from the QNode. (Double check if Lightning Adjoint supports this!) * [x] adjoint diff method: Does the Tape only contain operations deemed differentiable by the QJITDevice from the TOML spec? * [x] parameter-shit method: Does the Tape only contain operations that support the 2-term parameter shift rule? **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** The following PRs need to be merged before this one: - #609 Introduces device capabilities. - #712 Makes toml-independent tests possible. --------- Co-authored-by: David Ittah <dime10@users.noreply.github.com> Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com> Co-authored-by: Lillian <lillian542@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we implement a dedicated data structure representing quantum device capabilities. Previously we used toml document IR for this purpose. We see the following benefits in the new approach:
C(Gate)/Adjoint(Gate)syntax to minimum. We still use it only to communicate with PennyLane's APIIn subsequent PRs we will use it for program verification.
[sc-59478]