-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude OQD packages, modules and data from wheels #1403
Conversation
Confirming that there are no OQD files in the wheels: $ make wheel
$ unzip -l dist/*.whl | grep -i "oqd"
# No output |
Most of these changes can be reverted once OQD device support is complete and ready for release. However, note that the addition of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Joey! 🚀
We might even consider dropping the changelog entries altogether if the entire source is excluded from distribution, but that can be decided during the release prep :)
Thanks @dime10! I'm fine to leave the changelog entry in for now; I think it's mostly correct to say that an addition or modification to the source code that is not released is an "Internal change". Maybe we could also have an "Unreleased" section in the changelog for PRs like this. TBD during the release planning! |
**Context:** A number of OQD packages, modules and data files had been added recently (e.g. #1348 and #1355). However, as support for OQD devices is still under development, these files should not be included in the wheels. **Description of the Change:** Excludes _all_ OQD packages, modules and data files (such as toml config files) from the wheels. Furthermore, the OQD device entry in the [Supported devices documentation](https://docs.pennylane.ai/projects/catalyst/en/stable/dev/devices.html) has also been removed.
Context: A number of OQD packages, modules and data files had been added recently (e.g. #1348 and #1355). However, as support for OQD devices is still under development, these files should not be included in the wheels.
Description of the Change: Excludes all OQD packages, modules and data files (such as toml config files) from the wheels. Furthermore, the OQD device entry in the Supported devices documentation has also been removed.