-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect to OQD device runtime from Python layer #1420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mehrdad2m, looks good! Just had a minor suggestion for the changelog entry.
Co-authored-by: Joey Carter <joseph.carter@xanadu.ai>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1420 +/- ##
==========================================
- Coverage 96.91% 96.67% -0.24%
==========================================
Files 58 75 +17
Lines 6830 8216 +1386
Branches 782 853 +71
==========================================
+ Hits 6619 7943 +1324
- Misses 159 221 +62
Partials 52 52 ☔ View full report in Codecov by Sentry. |
Context:
A boilerplate Python OQD device was added in PR #1355. We want to verify that the infrastructure introduced in that PR is sufficient to generate OpenAPL in the runtime.
Description of the Change:
Added get_c_interface method for the OQD device to be able to point to the c++ implementation of the device in python.
This makes qjit to accept an instance of the OQD device and be able to connect to its runtime.
Benefits:
This allows for OQD runtime to be exposed to python, unlocking the next steps which are implementing the llvm lowering and the runtime methods.
Possible Drawbacks:
Related GitHub Issues:
[sc-73709]