Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to OQD device runtime from Python layer #1420

Merged
merged 9 commits into from
Jan 9, 2025

Conversation

mehrdad2m
Copy link
Contributor

@mehrdad2m mehrdad2m commented Jan 7, 2025

Context:
A boilerplate Python OQD device was added in PR #1355. We want to verify that the infrastructure introduced in that PR is sufficient to generate OpenAPL in the runtime.

Description of the Change:
Added get_c_interface method for the OQD device to be able to point to the c++ implementation of the device in python.
This makes qjit to accept an instance of the OQD device and be able to connect to its runtime.

Benefits:
This allows for OQD runtime to be exposed to python, unlocking the next steps which are implementing the llvm lowering and the runtime methods.

Possible Drawbacks:

Related GitHub Issues:
[sc-73709]

setup.py Outdated Show resolved Hide resolved
@mehrdad2m mehrdad2m changed the title Add OQD device entry point Connect to OQD device runtime from Python layer Jan 8, 2025
@mehrdad2m mehrdad2m requested a review from joeycarter January 8, 2025 15:04
Copy link
Contributor

@joeycarter joeycarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mehrdad2m, looks good! Just had a minor suggestion for the changelog entry.

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.67%. Comparing base (b8f6cb8) to head (a85bb0e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1420      +/-   ##
==========================================
- Coverage   96.91%   96.67%   -0.24%     
==========================================
  Files          58       75      +17     
  Lines        6830     8216    +1386     
  Branches      782      853      +71     
==========================================
+ Hits         6619     7943    +1324     
- Misses        159      221      +62     
  Partials       52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mehrdad2m mehrdad2m merged commit fa72766 into main Jan 9, 2025
42 checks passed
@mehrdad2m mehrdad2m deleted the add-oqd-device-entry-point branch January 9, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants