Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mouse scrolling from anywhere in Item Trader #7289

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Jan 23, 2024

Description of the problem being solved:

Local saw this during the PR review of #7234, so here's the technical fix. Can scroll with mouse from anywhere to scroll the bar, not only on the bar itself.

Link to a build that showcases this PR:

21 socket

eNqtHFt32jjzufsrODyTYMv3Pcl-h3BJ2CYNBRLafckRRoBTYVNbkJBf_40kA46LHTuwDylIcx_NaEYSe_G_1wWtrEkYeYF_WVXPlWqF-G4w8fzZZfVh2Dmzq__756-LHmbz--nVyqN85p-_vlyIzxVK1oReVh2jWmE4nBH2uCWlPQGpJfbZnAT-HX4Owutgcln9FvikWhljf-Kx7TeX4ij6hhfksjpwAblawZFL_ElzPx4DznGIXUbCW862sWLBXTCB2SmmEUwvsOcPAvcXYddhsFqCOtXK2iMvEqh717vvDxMyeX5SJtDpy0WP4g0JBwyzSgR_LqsNMA2ekRZewF-ghukKSCnnuo6Maj0X52oVRqwU4mBJyGQHq57rqpkF2gtJezolLvPWpBl6rDnHvpvgk4VXFvZuRZm3pB4JE3JlKnDzB3HDyYIdBgzTVm-QsI2JTMPOhw_Yx3KPPDa_omDKEtQ5Tnfme4yUROoFXhT4n9DjHUqmC1aUQrwVgu2TiIRrzLyUOJm0g8XY80tZ6Q77uBlEBXzAIXskhChmpRAGxA0g8MvyKIl5601JcchSesQIZaX5nB7tQVG40oQ_J1Afkl0xyEGwogUh2T73ICcTrEVe92BmZorq-nuWSM-htg6Y2Io-Ek_Ec_umt8-Puqqda4ZuGrqiqpmx1JtvIs_F9A6_eovVAlLnEP8ie4aqZuWsmNmc-ZAYMpEVLZNxxwvJZ_CaAZ18Cm-OgygL0db07PD2_BuoE3awDI8p-buivKqKRSaTaaZ57qfTHERMciMx4QAtb6d2_-bQXd8tFuAPfijyc3KDz2HAUfoQeLyUAOEL4-zZxAGccJGSz2xG_JjjJhFI51Ye1i0h7vwaHNXHjBTL2Dsoy0a55uXASfPm7koHzJtD_z1GCUtxxMOWUp3zXHYlLdX2STjbDOYeoXuNsl2fBN-K1sTLApjC1En0pMmRWYzhIYMUUq2kVUY4nBTbhMrKtMZRMtsjW883mIRP2srJTmQEilHAmJCilXcvDJ55bU_LoTXCRbAKC-yoXAUJnNQgezfc7lWym-mTycottjleUWjHiooPYlFaCqPBGHZ_tYLJjJRiUgpj12cJ1MFquYTEwb2fIqDm7rhQnXuJaudMQx9D38PiTUaxkrc1F2ewhy7MYFdwFOeSQimuCy8X0mzMIuCFWew8egfpYQGpXzTed0Gy91YyM2YHerJCDZYALNjo9YIXEH7Oj1CictBQWe3TfKYoIfHfNoXpvwMvxKDtT1YhD4fCPNIYh9gMvQXkzihqYYYrk7gkf8Shh32GxPFORHDozm_B-x1M6RiywWU1OSq-iSOhjkcZCVswxplywdIUVU6RM76oi8Mt_qm7WAYhq5BX_k8Ph2yzPW0SgGIE6ETM80XnDTmJ0mplMA9eGpM15zQMAhrtjqjwckn8yTsaw5CQCt5mGJcLIZTnXyoLHIHUG7liI65N4misOxFq-AEIAPWOZts1pOmWWlMVGzk1A2lWTTUty6jpjmrZMGAoCEAUZNU009T0mqbrtlZDqmPrNWSZhlnTdQQwpuZYZs0wkQO4pgG4pqJbqKbqyEGApQITZKoOwBiqo9R0QFYARoHPGlIcFSggG3jZmqbUDMdBQEGzkFYzEZAAeUzFAAoWMmoWfK4hRVEBULFNTl5XgIwG34C5A-MIeNk11VF1vQZiGGpNc2wT_sI_DuA6NigK7ZZR02xFByzbBoZAQQfxVWRqNdVCCtjFUFVQXTVBaQMmLKCv6SC-bZlgO6RbGhgGcWpAzATKtmKBWpbGTeiAVNDSaWAG2wFqBgL9NU0DAVXHgAEQEmyqmwrYCMwC2hpgEgDUQRMT-kLwieEogGSZYEDgCoYFI4AECDooreaAlhqyOEGD62qYBuhn2Lahg-E0bmHQmKOoIIRqG07NdjTudcAzbRssohvA29C4Ipqpgco2J6yqumNxdQAPCHFBFMNS-CrgIsDyAFfpsFBUExYMOMwEKZGlqwbnDgTAmQgk1kHMmmYY8Fd1LBWwQH9YRmAhDmNYXH0wfs20gJ8Bi84EU4KnwHoW9yayQAxdF4bjequKDksGOZoBxlJ0BN43EKxjXQMxwBTgOoQsYKdzeB7Z_DACh5vG-zDwPYg6BpGUOH9GWny0LOOEB9WXi4f-rfjwZc7YMvq7Xn95eTlfYjYPpuQVCq5zN1jUl4AE4XgW_fIoPeNk6w3472rWaEz7b-7ItH8P-331-89p4zpSRqPpfe86wG-P5Cpqft38PiPPY8P6sbFaM03tPlr_0eEP-tvtmuHSGT25m_Hv8Pd17zkE3129jub05nV-_zXCq_mi2TRu3bNRZ_l1c-sNF9ao_fp4Y_Wa6CG4Ne3Zy2J-q9y93r-o1ovzbc2-D85mnem_z2MbmZ3OjTV8alr_vrUHk4eHqNslw6b26oXf7zaQuV76DzPrbI1_Lu_8dbAMJp3usmH89_T6HAXad40a8_nIPDOCUdMYdldBw1o2-q0fbz-HP79N-347Mh87dzZ66niBc90cs_X9m-2b3_4LO7B4wjb5GipvT6PNf3prdEbYpouf3eXXq_GP1n047Pywmq235rPp_vbbTuD_bH93ns5Ub_17pINVLy-FY-pbz1zII_yoLr_xXT30IMPJLaHO06LI0Txv8g_fAkYiPscHt18uBtx1EeT-kF2TRXS1gW24w1uO1MFnnHg59IAwuackcS6rLFwRvldM8Yry8e8rTD2-DyAlOXwrb0L8IFzsDnWAFmwEvGSUJIebJc_UjdtbOdOgLKbG-W13BZn9Y4kq3mS_LUml-Mcmpq5Q-qLrL1es4otbkoUXuU_j1XTKbzyABQvFNU6702k3h93HdrytJlHEEn_yV4sxP-KX_24ZghREFPqVaDWO5MfL6qNHXoQgLcKwR2GrdwNK8TIiu31NCB1rQAEvh5qAuvF2FyWHae0Bsim1X0kI2_AMmkQ39EimXLv5D4SSDHkDycuQLGr8RiKbkGxQmrCJywY3w1Li3iebCr-IyVSHT-bgQgGDaSbnePYDSzC-bCHsvKnn8gou3-V8kUuoHLu4LhR_7ibH33F3lU1DXPFkEZCT2cjy2iYLO57Nsaq4Ksq0qpzNRm8RF2fqLiezkXdnJoEPZsqisoPKofQt8MUih6BpeJQ3QpmebVOyA8kmeM_mJIxr1SxKd5CjtiC5gRN64xXLDuMERI6txIFuhoX4XDaqPKvM0IHP5WSid4d3GQZNwmSTkidemYksD1U2xZn2i1vsHBfEp0kZ5pezOUbYHqll6B9P5wSJyL-NdeBN5DlLRrikwPISBhQWx5MRh0fHk0mfJh1PsQO17q9Mf8ez2egPzOOVyAEqsgIqRIQH1XEUeGwdR6GfLiT2uP38EkLkrxaZEjB0bgLbweT4l638FmxyLMe3BUkJsQ4Hwl61UrRkKj-oaWmKcoHG13p5a1iCfEAI9qKbnGqnGKXdAd8NwZS_0QjocQT_uL48Ss-ARdiftPgVxZGK8huO1RKIbSW7P1Su7l2apnpR3zYS4hiKl_bx4dmAhfy06S0IFj-hHzDVc01-i_scI-5toNBreWDuUCyTLS8O-IMfD5-rmrP_T_LsMmh24saLf972XauIyLcGI4KXgS-GEx1RDJoDFvdKcRdJA2ieAKc3hs6S6yIbHolVAX58Uh4N1PNRrghllcZ4E0WYVmR3WkEl8Lcs0zSM8jRQIRpiqjsBAuJwkE_y46MtrX_JC6EVOZJkVVSNwQtepuUwT2AP8wT2MAvaQxwdvjdIPFTCIlcBhHJaAq2EFjcEEvEfa-vYtfkpOx5yqnECp6onoKGXNMhnWB7S_xRBjgouSHEe_X5BxkMlFqSojUq57eASRkcuwDIhIEUu4-FrGqxJdMw6Oxx2xVOHqanp1CGGSnhKilDaTmrRdM-vIlL5Xg6VkPGwocusrsZiRQk7QRRpJ9gatIK2E9dh720XDx2y3aEFwu_WUgtEDhUkIO5iUhLIoaO9p5deckUTmLhEey90PFRQa3FzlCIgh0po3YcG4jN5W26ApbPQsZnWKO2O48sLdDSF42XQjzWcXjQR8svbVCKUQwVXpbjgTu3LcuhUpbNWyhaTTUWevZ1-AzROVTcW3aXE84NUopRDpYrwTJOgY1eZWZbA0WWMeZrFYBwtSJlVKZKueqyx1RPs8fqpSn_jNH4wj6yki6Y5_oQjVTCIkaPrhWNbAfU0dixau4m3PamMIofKZ2t0dLbOJfSZLv1zxjxVTJzIl5-O0aKxwB-mpYJBDhXc8vmLtPf4cqQgunjple69xFDR_oG_e0otYjlUtH_gD-vSFhBDZfbVA9F8sgqhcFPBX--legI59Jl4Pv54B51k0zpkkZPtXH8SuqjHZ-fyUW2IJ2QgDvlHhD_SjmJm_G3uixjhv_oVj6Bh0VM85uf9_DFzRbyYev8Kup6BrJwbe-TdfUzlxmMVeR2T-vVcLOhB4aT88t1T4E-92fZFsUvmAZ2QMDYL8cliE_-IevuSyUr-mOcQfPIX0VskIx_l_c8hEq-mUPJHIFnM0ljaBwLGP7oIKO1jP4loZSMudj_b5r9RJiGZDMRDpGDlswGh04TMH-i63UF28BYy7XyU3c3_FsfW7GyUyJt59H4qnrSDkOLt-PtnaBf1rdcv6un_D8H_AXzYGsM=

@Peechey Peechey added the technical Hidden from release notes label Jan 23, 2024
@Peechey
Copy link
Contributor Author

Peechey commented Jan 24, 2024

Closing for now as I have a scrollbar cleanup/refactor that includes this change. If that PR ends up being too large in scope, I'll reopen this one.

@Peechey Peechey closed this Jan 24, 2024
@Peechey Peechey deleted the feature/item_trader_scroll_wheel branch July 17, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Hidden from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant