Fix display in Item Trader when large number of sockets are allocated #7234
Conversation
…ar controls of TradeQuery every time you close, update anchoring to sectionAnchor instead of dynamically to each created row
|
Alternate solution for getting the scrollBar functionality: Removes the need to pass a function through Main:OpenPopup and PopupDialog, instead uses a Global index that PopupDialog is looking for in self.controls to run inside of Draw(). However it does require an invisible ButtonControl to attach the function and use the Click() function. Here is the direct compare between my solutions: https://github.com/Peechey/PathOfBuilding/compare/feature/popup_scrollbar_tradeQuery...Peechey:PathOfBuilding:feature/popup_scrollbar_tradeQuery_alternate?expand=1 |
Peechey
changed the title
Fixes #7229
Description of the problem being solved:
Add a scrollBar to the Trader popup when the number of sockets reach a certain point. This allows the popup to show on even the smallest window PoB can be resized to. The rows are dynamically shown given they are within the scrollBar height, and in order to do this I had to change the anchoring from the row above it to a static sectionAnchor for all of them. That anchor is what is moved when the scrollBar offsets.
There are still some arbitrary numbers I used to fine-tune the UI so it would hide/show cleaner. The numbers in the hideShowFunc were trial and error, again whatever looked best personally.
I also fixed another odd bug I found where if you deallocate a socket after opening the Trader, and then opened it again, the previous socket controls still existed in the popup. I added a wipeTable in the close function for both the "Done" button and hitting escape so it's a clean slate every time you open the popup. The code related to this is the wipeTable in close() and adding "close" to the OpenPopup call at the bottom.
This PR also introduces a clean-ish way for any popup to use a scrollBar if needed, which wasn't easily possible before.
Link to a build that showcases this PR:
21 socket
6 socket
Before screenshot:
21 sockets
After screenshot:
21 sockets
6 sockets, scrollBar shows starting at 7
