Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemCondition fixes. Kalandra's Touch not adding to influenced items multiplier. #7182

Merged
merged 4 commits into from
Dec 31, 2023

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Dec 29, 2023

Fixes #7179, #7145. Contains #7152

Description of the problem being solved:

Fixes issues with ItemCondition condition not working properly when no matching items were found.
Implements handling for explicit keyword in mods using ItemCondition .
Fixes Kalandra's Touch not adding to the CorruptedItem multiplier even if the other ring was corrupted.

@Wires77
Copy link
Member

Wires77 commented Dec 29, 2023

I'm guessing there is also an issue here with number of Shaper/Elder items, too

@Paliak Paliak changed the title Make Kalandra's Touch count as corrupted if other ring is corrupted. ItemCondition fixes. Kalandra's Touch not adding to influenced items multiplier. Dec 29, 2023
@Paliak Paliak added bug: calculation Numerical differences bug: behaviour Behavioral differences labels Dec 29, 2023
@LocalIdentity LocalIdentity merged commit 5f9ed2c into PathOfBuildingCommunity:dev Dec 31, 2023
2 checks passed
@Paliak Paliak deleted the issue-7179 branch January 20, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kalandra's Ring/Shadowstitch Interaction
3 participants