Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a second ring to the build which has only ES on it (energy shield) reduces total energy shield #7145

Closed
3 tasks done
vajura opened this issue Dec 22, 2023 · 3 comments
Labels
bug: calculation Numerical differences

Comments

@vajura
Copy link

vajura commented Dec 22, 2023

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Check for support

  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What is the value from the calculation in-game?

I am only doing the build in PoB, but its just adding a plain white ES Moonstone ring

What is the value from the calculation in Path of Building?

Adding the second plain white Moonstone ring (only energy shield on it) reduces my total energy shield. Same thing happens when the ES is explicit mods, or combined with other mods. I just did it with a Moonstone ring for ease of pointing the problem down. https://i.imgur.com/mnfKObM.png

This is not only a error with the preview when i equip it my ES drops for the previewed amount.

The build has no interaction that would cause this in any shape or form

How to reproduce the issue

  1. Import build: https://pobb.in/jVAQER06J3wk
  2. In items select the second ring slot and put in the plain white Moonstone ring (or create new one with ES)
  3. Total ES will drop

Character build code

https://pobb.in/jVAQER06J3wk

Screenshots

https://i.imgur.com/mnfKObM.png

@vajura vajura added the bug: calculation Numerical differences label Dec 22, 2023
@Peechey
Copy link
Contributor

Peechey commented Dec 22, 2023

More info for devs: it has to do with the Evasion and Energy Shield Mastery that gives 20% increased max ES if both rings have an explicit evasion mod. Something with that mastery seems off. Even on a brand new build if you path straight to that mastery with zero gear, it's still adding the ES.

image

image

@Wires77
Copy link
Member

Wires77 commented Dec 22, 2023

I looked into this earlier as well. Definitely an issue with it applying without any items equipped that has to do with this commit to support Utula's: 1f843db

The mastery itself doesn't work because GGG changed the wording to include "explicit". The code will have to be refactored slightly to support that. Would be useful to have some tests to cover all these cases

@Paliak
Copy link
Contributor

Paliak commented Jan 7, 2024

#7182 has been merged. Should be fixed in next release.

@Paliak Paliak closed this as completed Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
4 participants