-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enemy dot skills #6809
Merged
LocalIdentity
merged 9 commits into
PathOfBuildingCommunity:dev
from
Regisle:EnemyDotSkills
Jul 22, 2024
Merged
Enemy dot skills #6809
LocalIdentity
merged 9 commits into
PathOfBuildingCommunity:dev
from
Regisle:EnemyDotSkills
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regisle
force-pushed
the
EnemyDotSkills
branch
from
December 4, 2023 23:59
a389edf
to
ec3f1b6
Compare
Siruis storm still missing but otherwise should be good to merge, the storm can be added later |
Regisle
force-pushed
the
EnemyDotSkills
branch
from
January 20, 2024 02:52
ec3f1b6
to
6e30126
Compare
3 tasks
LocalIdentity
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on #5754 and #6803 those must be merged firstonly the last 7 commits are unique atm
Adds support for enemy damage type of damage over time, this makes the configuration options apply to damage over time instead, and added a new section for it in calcs tab, as well as added shaper beam as a damage over time boss skill
Theres still a few things I wish to do, improve the breakdowns and implement total net regen taking enemy degens and recoup/petrified blood degens into accountI would also like to add more boss degens, Sirus Storm
and Cortex ground degen are the 2 thatcomes to mind at the momentSirus storm doesnt seem to be a skill and is a buff
atlas_orion_death_zone / atlas_orion_death_zone_core
so unsure how to export it correctly, and Have not looked at cortex yetedit: added cortex degen, and improved the breakdowns, at the moment theres no way to have an enemy degen and recoup at the same time, so leaving this for a future PR that adds enemy ailments or multi type skills or recoup based on self damage, IMO only thing left to check is there are no more crashes/issues with the new damage type and then add sirus storm degen