Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address: Service Read lifecycle wasn't detecting drift for auto pause notif and alert grouping params #673

Conversation

imjaroiswebdev
Copy link
Contributor

Closes #626 and #574

Test cases introduced...

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyServiceWithAlertGroupingParameters_import -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
=== RUN   TestAccPagerDutyServiceWithAlertGroupingParameters_import
--- PASS: TestAccPagerDutyServiceWithAlertGroupingParameters_import (15.43s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   15.710s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyServiceWithAutoPauseNotifications_import -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
=== RUN   TestAccPagerDutyServiceWithAutoPauseNotifications_import
--- PASS: TestAccPagerDutyServiceWithAutoPauseNotifications_import (15.27s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   15.493s

Additionally make `alert_grouping_parameters` Computed for the Provider
to fill correctly imported states and detect drift in the attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pagerduty_service import misses alert_grouping_parameters and auto_pause_notifications_parameters
1 participant