Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.238、239、240、241】 Migrate nn.initializer.XavierInitializer, nn.initializer.MSRAInitializer into pir #59419

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

MarioLulab
Copy link
Contributor

@MarioLulab MarioLulab commented Nov 27, 2023

PR types

Others

PR changes

Others

Description

任务 issue: #58067

  1. 将 paddle.nn.initializer.KaimingNormal 迁移升级至 pir,并更新单测,单测覆盖率(1/1)

  2. 将 paddle.nn.initializer.KaimingUniform 迁移升级至 pir,并更新单测,单测覆盖率(1/1)

  3. 将 paddle.nn.initializer.XavierNormal 迁移升级至 pir,并更新单测,单测覆盖率(1/1)

  4. 将 paddle.nn.initializer.XavierUniform 迁移升级至 pir,并更新单测,单测覆盖率(1/1)

NOTE:

  1. test/legacy_test/test_initializer_nn.py 下的 TestXavierNormal 单测和 test/legacy_test/test_initializer.py 下的
    TestXavierInitializer 单测相同,故前者不做迁移
  2. test/legacy_test/test_initializer_nn.py 下的 TestKaimingInitializer 和 TestKaimingInitializer 单测和 test/legacy_test/test_initializer.py 下的 TestMSRAInitializer 单测相同,故前者不做迁移
  3. test/legacy_test/test_layers.py 下的 test_batch_fc 单测使用 paddle.nn.initializer.XavierNormal 为 paddle.incubate.layers.nn.batch_fc 初始化参数,而该 api 为静态图专用 api,未找到动态图下相应 api,故不作迁移
  4. test/legacy_test/test_layers.py 下的 test_rank_attention 单测使用 paddle.nn.initializer.XavierNormal 为 paddle.incubate.layers.nn.rank_attention 初始化参数,而该 api 为静态图专用 api,未找到动态图下相应 api,故不作迁移

Copy link

paddle-bot bot commented Nov 27, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 27, 2023
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@0x45f 0x45f merged commit c924624 into PaddlePaddle:develop Dec 4, 2023
29 checks passed
SigureMo pushed a commit to gouzil/Paddle that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants