【PIR API adaptor No.14-15】Assign and Bilinear #58876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liyulingyue
commented
Nov 9, 2023
Liyulingyue
commented
Nov 9, 2023
Closed
|
Sorry to inform you that b58508d's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
MarioLulab
reviewed
Nov 28, 2023
test/legacy_test/test_initializer.py
Outdated
| @@ -541,6 +542,7 @@ def test_msra_initializer_bf16(self): | |||
|
|
|||
|
|
|||
| class TestBilinearInitializer(unittest.TestCase): | |||
| @test_with_pir_api | |||
There was a problem hiding this comment.
initializer 相关的 pir 单测无法适配旧 ir，所以需要单独新增 pir 下的单测，可以参考：#59419
test/legacy_test/test_initializer.py
Outdated
| @@ -628,6 +630,7 @@ def test_bilinear_initializer_fp16(self): | |||
|
|
|||
|
|
|||
| class TestNumpyArrayInitializer(unittest.TestCase): | |||
| @test_with_pir_api | |||
MarioLulab
reviewed
Dec 11, 2023
test/legacy_test/test_initializer.py
Outdated
| with paddle.static.program_guard(main, startup): | ||
| param = paddle.pir.core.create_parameter( | ||
| dtype=dtype, | ||
| shape=[5, 10], |
There was a problem hiding this comment.
shape 应与 TestBilinearInitializer.test_bilinear_initializer 单测对齐
test/legacy_test/test_initializer.py
Outdated
Comment on lines
902
to
903
| num_ops = 2 if dtype in ["float16", "uint16"] else 1 | ||
| self.assertEqual(len(checked_ops), num_ops) |
test/legacy_test/test_initializer.py
Outdated
| num_ops = 2 if dtype in ["float16", "uint16"] else 1 | ||
| self.assertEqual(len(checked_ops), num_ops) | ||
| init_op = checked_ops[0] | ||
| self.assertEqual(init_op.type, 'assign_value') |
There was a problem hiding this comment.
不用再去检查 init_op.type，因为前面的 self.get_init_ops_by_op_name 就是根据 op_name 去获取 op 的。这里改成
self.assertEqual(len(checked_ops), 1)即可
test/legacy_test/test_initializer.py
Outdated
| def test_numpy_array_initializer_bf16(self): | ||
| """Test the numpy array initializer with bfloat16""" | ||
| block = self.test_numpy_array_initializer("uint16") | ||
| self.assertTrue(block.ops[1]) |
Liyulingyue
commented
Dec 17, 2023
Liyulingyue
commented
Dec 17, 2023
Liyulingyue
commented
Dec 17, 2023
Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>
Liyulingyue
commented
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
#58067 14-15