Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] add types and fix ut for stack op #59375

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

houj04
Copy link
Contributor

@houj04 houj04 commented Nov 26, 2023

PR types

New features

PR changes

OPs

Description

  • stack算子及其反向stack_grad增加新的类型,准确说是“对齐”了前向和反向支持的类型。
  • 现有版本的单测中,没有正确使用in_type,而是固定使用了float32,本PR修复了此问题。
  • 现有版本的单测中,不知道什么原因跳过了若干反向的检查,本PR删除了这些跳过的操作。
  • 修复了一些历史遗留问题:[XPU] refine scale_value in AdamW #58805 里面的一些magic number换成了更优雅的写法;[XPU] add squared_l2_norm op #59066 里面多余的空行删除掉了。

Copy link

paddle-bot bot commented Nov 26, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 26, 2023
Copy link
Contributor

@zhangyk0314 zhangyk0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cqulilujia cqulilujia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houj04 houj04 merged commit 68436e5 into PaddlePaddle:develop Nov 27, 2023
28 checks passed
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants