[XPU] refine scale_value in AdamW #58805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houj04
changed the title
tianshuo78520a
approved these changes
Nov 9, 2023
houj04
changed the title
YuanRisheng
approved these changes
Nov 13, 2023
QingshuChen
approved these changes
Nov 13, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* [XPU] fix adamw optimizer state_dict * fix typo * rename scale to scale_value * revert unnecessary codes. * remove scale_value from DenseTensorMeta * fix typo
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* [XPU] fix adamw optimizer state_dict * fix typo * rename scale to scale_value * revert unnecessary codes. * remove scale_value from DenseTensorMeta * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
APIs
Description
在之前的PR #57077 中，给XPU下的
DenseTensor新增了scale_value属性。该PR有两个问题：（1）对
DenseTensor的内存布局有影响（2）没有支持优化器的state_dict和set_state_dict功能，因此在使用checkpoint进行训练状态保存和恢复的时候会有问题。本PR对上述两个问题进行了优化和修复。