[New-IR] add pass registry #56729
Merged
[New-IR] add pass registry #56729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhiqiu
force-pushed
the
dev/add_pass_registry
branch
from
7233626
to
4d29549
Compare
yuanlehome
approved these changes
Aug 29, 2023
| @@ -514,7 +508,8 @@ void BindPassManager(pybind11::module *m) { | |||
| py::arg("opt_level") = 2) | |||
| .def("add_pass", | |||
| [](PassManager &self, std::string pass_name) { | |||
There was a problem hiding this comment.
std::string作为函数参数，最好还是const&吧
There was a problem hiding this comment.
fix it in the next pr
| ) # apply pass to elimitate dead code | ||
| pm.run(new_program) | ||
| op_names = [op.name() for op in new_program.block().ops] | ||
| # print(op_names) | ||
| # TODO(zhiqiu): unify the name of pass |
There was a problem hiding this comment.
可以考虑所有的pass name都统一改为小写加下划线形式
There was a problem hiding this comment.
fix it in the next pr
BeingGod
pushed a commit
to BeingGod/Paddle
that referenced
this pull request
Sep 9, 2023
* add pass registry * add pass registry macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
[New-IR] add pass registry
Pcard-67164