Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IR] Refine PhiKernelOp attributes name and delete some unused code2 #54944

Merged
merged 23 commits into from
Jun 29, 2023
Merged

[IR] Refine PhiKernelOp attributes name and delete some unused code2 #54944

merged 23 commits into from
Jun 29, 2023

Conversation

zhangbo9674
Copy link
Contributor

@zhangbo9674 zhangbo9674 commented Jun 28, 2023 •
edited
Loading

PR types

Function optimization

PR changes

APIs

Description

本 pr 完善了 IR 多个遗留问题，包括：

Others

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Jun 28, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhangbo9674 zhangbo9674 mentioned this pull request Jun 28, 2023
Merged
yuanlehome
yuanlehome reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@yuanlehome yuanlehome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

winter-wang
winter-wang approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangbo9674 zhangbo9674 merged commit a7419ff into PaddlePaddle:develop Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanlehome yuanlehome yuanlehome left review comments

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@winter-wang winter-wang winter-wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangbo9674 @yuanlehome @XiaoguangHu01 @winter-wang