[IR] Refine PhiKernelOp attributes name and delete some unused code #54891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
winter-wang
reviewed
Jun 28, 2023
| } | ||
|
|
||
| const std::string PhiKernelOp::op_name() { | ||
| return operation() |
There was a problem hiding this comment.
这儿直接调用 attributes()就可以。没必要加 operation()吧。后面的类似。
winter-wang
reviewed
Jun 28, 2023
| @@ -26,6 +27,9 @@ class PhiKernelOp : public ir::Op<PhiKernelOp> { | |||
| static const char *name() { return "phi.kernel"; } | |||
| static constexpr uint32_t attributes_num = 3; | |||
| static const char *attributes_name[attributes_num]; | |||
| const std::string op_name(); | |||
There was a problem hiding this comment.
要么返回 const string& ,要么返回string。 返回const string感觉没啥意义。后面类似。
winter-wang
reviewed
Jun 28, 2023
| @@ -143,7 +143,7 @@ class {op_name} : public ir::Op<{op_name}{interfaces}{traits}> {{ | |||
| }} | |||
| """ | |||
| OP_INFER_SHAPE_TEMPLATE = """ | |||
| void {op_name}::InferShape( phi::InferMetaContext *infer_meta ) {{ | |||
There was a problem hiding this comment.
InferMeta的生成逻辑是不是可以类似verify， 单独抽一个python文件出来？ 感觉op_gen.py里面内容有点太多了。
kangguangli
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
APIs
Description
本 pr 完善了 IR 多个遗留问题，包括：
Others
Pcard-67164