【PaddlePaddle Hackathon 4】No.63 add fp16 and bf16 for eye and frame #51819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longranger2
changed the title
|
还有想问下CI-Windows-Inference的报错应该如何解决呢？
|
Vvsmile
reviewed
Mar 20, 2023
| or not core.is_bfloat16_supported(core.CUDAPlace(0)), | ||
| "core is not complied with CUDA and not support the bfloat16", | ||
| ) | ||
| class TestEyeBF16(OpTest): |
There was a problem hiding this comment.
修改类名TestEyeBF16为TestEyeBF16OP
Vvsmile
reviewed
Mar 20, 2023
| or not core.is_bfloat16_supported(core.CUDAPlace(0)), | ||
| "core is not complied with CUDA and not support the bfloat16", | ||
| ) | ||
| class TestFrameBF16(OpTest): |
There was a problem hiding this comment.
修改类名TestFrameBF16为TestFrameBF16OP
Vvsmile
reviewed
Mar 20, 2023
| def setUp(self): | ||
| self.op_type = "frame" | ||
| self.python_api = paddle.signal.frame | ||
| self.__class__.op_type = self.op_type |
There was a problem hiding this comment.
这个应该不用在这里设置，OpTest框架里有对应的设置
|
@Vvsmile 好的，还想问下这个报错需要解决吗？
|
这个是前向精度问题，请看一下相关实现里有没有需要转换FP32计算的地方，目前ReRun也可以显示前向差异大小，可用做参考 |
ZzSean
reviewed
Mar 28, 2023
| 'num_rows': 219, | ||
| 'num_columns': 319, | ||
| } | ||
| self.outputs = {'Out': convert_float_to_uint16(np.eye(219, 319))} |
ZzSean
reviewed
Mar 28, 2023
| def setUp(self): | ||
| self.op_type = "frame" | ||
| self.python_api = paddle.signal.frame | ||
| self.shape, self.dtype, self.attrs = self.initTestCase() |
There was a problem hiding this comment.
@ZzSean 有的，initTestCase()会返回 np.uint16
ZzSean
reviewed
Apr 4, 2023
| self.python_api = paddle.signal.frame | ||
| self.shape, self.dtype, self.attrs = self.initTestCase() | ||
| x = np.random.random(size=self.shape).astype(np.float32) | ||
| out = frame_from_librosa(x, **self.attrs) |
There was a problem hiding this comment.
与diagonal问题类似，这里也需要加个.copy()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
相关链接：
#51281
原来的PR：#51531