【PaddlePaddle Hackathon 4】No.63 fix eye and frame #51531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
标题中加一下NO 序号 |
longranger2
changed the title
|
@ZzSean 辛苦review下～ |
longranger2
changed the title
longranger2
changed the title
ZzSean
reviewed
Mar 15, 2023
paddle/phi/kernels/eye_kernel.h
Outdated
| @@ -16,6 +16,7 @@ | |||
|
|
|||
| #include "paddle/phi/common/scalar.h" | |||
| #include "paddle/phi/core/dense_tensor.h" | |||
| #include "paddle/phi/core/device_context.h" | |||
paddle/phi/kernels/gpu/eye_kernel.cu
Outdated
| #include "paddle/phi/backends/gpu/gpu_context.h" | ||
| #include "paddle/phi/common/data_type.h" |
| @@ -178,6 +179,53 @@ def test_error(self): | |||
| paddle.eye(-1) | |||
|
|
|||
|
|
|||
| @unittest.skipIf( | |||
| self.op_type = "eye" | ||
| self.dtype = np.float16 | ||
| self.python_api = paddle.eye | ||
| self.__class__.op_type = self.op_type |
| or not core.is_float16_supported(core.CUDAPlace(0)), | ||
| "core is not complied with CUDA and not support the float16", | ||
| ) | ||
| class TestEyeFP16OP(OpTest): |
There was a problem hiding this comment.
是否可以对TestEyeOp做一些修改，然后直接继承，增加一个init_dtype函数，只修改self.dtype，可以参考#50723
| @@ -137,5 +138,96 @@ def initTestCase(self): | |||
| return input_shape, input_type, attrs | |||
|
|
|||
|
|
|||
| @unittest.skipIf( | |||
| or not core.is_float16_supported(core.CUDAPlace(0)), | ||
| "core is not complied with CUDA and not support the float16", | ||
| ) | ||
| class TestFrameFP16OP(OpTest): |
| self.__class__.op_type = self.op_type | ||
| self.shape, self.dtype, self.attrs = self.initTestCase() | ||
| x = np.random.random(size=self.shape).astype(np.float32) | ||
| out = frame_from_librosa(x, **self.attrs).astype(np.float64) |
| def test_check_output(self): | ||
| paddle.enable_static() | ||
| place = core.CUDAPlace(0) | ||
| self.check_output_with_place(place, atol=1e-3) |
| place, | ||
| ['X'], | ||
| 'Out', | ||
| max_relative_error=1e-2, |
|
修改好了～，新的PR为：#51819 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
相关链接：
#51281