Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix xpu unittest issue #49760

Merged
merged 2 commits into from
Jan 13, 2023
Merged

fix xpu unittest issue #49760

merged 2 commits into from
Jan 13, 2023

Conversation

XiaociZhang
Copy link
Contributor

@XiaociZhang XiaociZhang commented Jan 12, 2023

PR types

Others

PR changes

Others

Describe

fix two failures in xpu unittest

  1. zero_dim_tensor: retain_grad property is not set for sigmoid_focal_loss test
  2. flatten: [PHI]Rename some PHI Kernel #49470 introduce another issue when renaming kernel flatten_with_xshape

@paddle-bot
Copy link

paddle-bot bot commented Jan 12, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jan 12, 2023
@XiaociZhang XiaociZhang changed the title revert #49616 for xpu unittest fix xpu unittest issue: zero_dim_tensor Jan 12, 2023
@XiaociZhang XiaociZhang changed the title fix xpu unittest issue: zero_dim_tensor fix xpu unittest issue Jan 13, 2023
phi::DataType::INT32,
phi::DataType::INT8,
phi::DataType::FLOAT16,
phi::DataType::FLOAT32})},
{"flatten_grad",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和这个flatten有关 ? 为啥去掉这个

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前是切phi导致flatten_with_x_shape找不到,我添加的。paddle改完后就用不着了,可以删掉。

@houj04 houj04 merged commit ddc8a72 into PaddlePaddle:develop Jan 13, 2023
@paddle-bot
Copy link

paddle-bot bot commented Jan 13, 2023

你的PR已合入Paddle库,请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

yjjiang11 pushed a commit to yjjiang11/Paddle that referenced this pull request Jan 13, 2023
* fix xpu unittest issue: zero_dim_tensor

* deal with leftout issue introduced by PaddlePaddle#49470
@XiaociZhang XiaociZhang deleted the unittest branch January 13, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants