[PHI]Rename some PHI Kernel #49470
Merged
[PHI]Rename some PHI Kernel #49470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jiahy0825
previously approved these changes
Jan 5, 2023
zyfncg
reviewed
Jan 5, 2023
| "reshape_with_xshape", {"X"}, {"shape"}, {"Out", "XShape"}); | ||
| return KernelSignature("reshape", {"X"}, {"shape"}, {"Out", "XShape"}); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
没有xshape的分支是不需要分发到reshape_infer的kernel？
zyfncg
reviewed
Jan 5, 2023
paddle/phi/ops/compat/einsum_sig.cc
Outdated
| @@ -31,7 +29,7 @@ KernelSignature EinsumGradOpArgumentMapping(const ArgumentMappingContext& ctx) { | |||
| } | |||
| } // namespace phi | |||
|
|
|||
| PD_REGISTER_BASE_KERNEL_NAME(einsum, einsum_raw); | |||
| PD_REGISTER_BASE_KERNEL_NAME(einsum, einsum); | |||
|
CustomDevice需要改吗？如果需要的话，建议也一起改了 |
谢谢提醒，这个在另一个PR，已补充到描述中 |
zyfncg
approved these changes
Jan 10, 2023
XiaociZhang
added a commit
to XiaociZhang/Paddle
that referenced
this pull request
Jan 13, 2023
houj04
pushed a commit
that referenced
this pull request
Jan 13, 2023
* fix xpu unittest issue: zero_dim_tensor * deal with leftout issue introduced by #49470
yjjiang11
pushed a commit
to yjjiang11/Paddle
that referenced
this pull request
Jan 13, 2023
* rename kernel * delete sig * modify code according comment * fix ci bugs
yjjiang11
pushed a commit
to yjjiang11/Paddle
that referenced
this pull request
Jan 13, 2023
* fix xpu unittest issue: zero_dim_tensor * deal with leftout issue introduced by PaddlePaddle#49470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
规范化以下Kernel有关命名：
flatten_with_xshape，reshape_with_xshape，einsum_raw，prod_raw,squeeze_with_xshape,unsqueeze_with_xshape
异构设备的相关修改：PaddlePaddle/PaddleCustomDevice#355