Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI FIX] Revert "Replace matmul with matmul_v2 during oneDNN fuse passes" #49524

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

Silv3S
Copy link
Member

@Silv3S Silv3S commented Jan 4, 2023

PR types

Bug fixes

PR changes

Others

Describe

Reverts #49108

After all CI checks were complete, #48848 was merged. Code didn't have any merge conflicts, but unfortunately changes done in op_desc.cc (changing order of runtime and base attributes) can't work in case of matmul operator. That's because runtime attributes of matmul (v1) are overwritten by default values from OPMaker.

I will rework this PR to be compatible with current develop.

@paddle-bot
Copy link

paddle-bot bot commented Jan 4, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jan 4, 2023
@paddle-bot
Copy link

paddle-bot bot commented Jan 4, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@Silv3S Silv3S added the Intel label Jan 4, 2023
@Silv3S Silv3S requested a review from zyfncg January 4, 2023 00:18
@chalsliu chalsliu merged commit 338cbea into PaddlePaddle:develop Jan 4, 2023
@paddle-bot
Copy link

paddle-bot bot commented Jan 4, 2023

你的PR已合入Paddle库,请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

@Silv3S Silv3S deleted the revert-49108-clean_matmuls branch January 4, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers Intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants