Replace matmul with matmul_v2 during oneDNN fuse passes #49108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
reviewed
Dec 21, 2022
Comment on lines
+86
to
+88
| if (matmul_alpha != 1.0f) { | ||
| matmul_op->SetAttr("alpha", matmul_alpha); | ||
| } |
There was a problem hiding this comment.
alpha is not a attribute of matmul_v2, I'm not sure whether this alpha can work in kernel of matmul_v2, please do a check ~
There was a problem hiding this comment.
Yes, it works because alpha is added as extra OneDNN-specific attribute in ops_extra_info.h. I'm aware that it's not elegant solution, so in next PR I will introduce fused_matmul with all necessary attributes declared in OPMaker.
zyfncg
approved these changes
Dec 21, 2022
zhangting2020
approved these changes
Dec 29, 2022
YuanRisheng
approved these changes
Dec 29, 2022
|
@jczaja please merge |
Silv3S
added a commit
to Silv3S/Paddle
that referenced
this pull request
Jan 3, 2023
…lePaddle#49108)" This reverts commit 2c444df.
chalsliu
pushed a commit
that referenced
this pull request
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
During PHI migration
matmul_v2kernel was migrated to PHI andmatmulwas left in common matmul_v2_mkldnn_op.cc file which could lead to many misunderstandings in a future. Also we have maintained support for both operators in each fuse pass, although they share same oneDNN kernel.After merging this PR it will be easier to introduce
fused_matmuland remove extra attributes from base operator.Changes made in this PR:
matmulwithmatmul(v2)during fuse passes,matmuloperator and kernel,