Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHI decoupling] remove "paddle/fluid/platform/dynload/xxx.h" in phi #47787

Merged
merged 5 commits into from
Nov 9, 2022

Conversation

huangjiyi
Copy link
Member

@huangjiyi huangjiyi commented Nov 9, 2022

PR types

Others

PR changes

Others

Describe

remove "paddle/fluid/platform/dynload/xxx.h" in phi, including cudnn.h, mklml.h and rocblas.h.
("paddle/fluid/platform/dynload/cublas.h" has been removed in #47778 )

修改:将 #include "paddle/fluid/platform/dynload/xxx.h" 替换为 #include "paddle/phi/backends/dynload/xxx.h",然后将相关代码文件中的 paddle::platform::dynload:: 替换为 phi::dynload::

@paddle-bot
Copy link

paddle-bot bot commented Nov 9, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 9, 2022
@huangjiyi huangjiyi changed the title [phi] remove "paddle/fluid/platform/dynload/xxx.h" in phi [PHI decoupling] remove "paddle/fluid/platform/dynload/xxx.h" in phi Nov 9, 2022
@huangjiyi
Copy link
Member Author

@luotao1 ,我申请一下编辑 tracking issue #47615 的权限

@luotao1
Copy link
Contributor

luotao1 commented Nov 9, 2022

我申请一下编辑 tracking issue #47615 的权限

抱歉,之前没注意到没有write权限的同学无法编辑别人的issue,我们会帮忙进行编辑的。

@luotao1 luotao1 requested a review from ZzSean November 9, 2022 09:48
@luotao1
Copy link
Contributor

luotao1 commented Nov 9, 2022

@ZzSean 帮忙看下 Op-benchmark的问题

Copy link
Contributor

@JamesLim-sy JamesLim-sy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark.

@YuanRisheng YuanRisheng merged commit 7c30253 into PaddlePaddle:develop Nov 9, 2022
@luotao1
Copy link
Contributor

luotao1 commented Nov 10, 2022

我申请一下编辑 tracking issue #47615 的权限

加油,祝你早日能成为 Committer ,见 飞桨框架代码仓库的角色及权限介绍 。参考 #45841

@huangjiyi
Copy link
Member Author

我申请一下编辑 tracking issue #47615 的权限

加油,祝你早日能成为 Committer ,见 飞桨框架代码仓库的角色及权限介绍 。参考 #45841

谢谢,看来我还需要学很多东西。

@huangjiyi huangjiyi deleted the decouple_dynload branch November 16, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants