Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHI decoupling] remove "paddle/fluid/platform/dynload/cublas.h" in phi #47778

Merged
merged 1 commit into from
Nov 9, 2022
Merged

[PHI decoupling] remove "paddle/fluid/platform/dynload/cublas.h" in phi #47778

merged 1 commit into from
Nov 9, 2022

Conversation

huangjiyi
Copy link
Member

@huangjiyi huangjiyi commented Nov 8, 2022 •
edited by luotao1
Loading

PR types

Others

PR changes

Others

Describe

remove "paddle/fluid/platform/dynload/cublas.h" in phi

修改：将头文件 paddle/fluid/platform/dynload/cublas.h 替换为 paddle/phi/backends/dynload/cublas.h，将代码中的 paddle::platform::dynload:: 替换为 phi::dynload::

@paddle-bot
Copy link

paddle-bot bot commented Nov 8, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@SigureMo SigureMo mentioned this pull request Nov 8, 2022
Closed
@paddle-bot-old paddle-bot-old bot added the contributor External developers label Nov 8, 2022
@huangjiyi huangjiyi mentioned this pull request Nov 9, 2022
Merged
@luotao1
Copy link
Contributor

luotao1 commented Nov 9, 2022

PR-CI-OP-benchmark 如果这次失败的话，无需重跑，请 @ZzSean 看下是否能豁免

@huangjiyi huangjiyi mentioned this pull request Nov 9, 2022
Merged
@huangjiyi huangjiyi changed the title [phi] remove "paddle/fluid/platform/dynload/cublas.h" in phi [PHI decoupling] remove "paddle/fluid/platform/dynload/cublas.h" in phi Nov 9, 2022
@huangjiyi
Copy link
Member Author

@ZzSean，帮忙看一下 PR-CI-OP-benchmark 出现的问题。

ZzSean
ZzSean approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for CI-OP-Benchmark

@luotao1 luotao1 merged commit 692a963 into PaddlePaddle:develop Nov 9, 2022
@huangjiyi huangjiyi deleted the decouple_cublas_h branch November 16, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@ZzSean ZzSean ZzSean approved these changes

Assignees

@luotao1 luotao1

@YuanRisheng YuanRisheng

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huangjiyi @luotao1 @YuanRisheng @ZzSean