add adadelta op for xpu, test=kunlun #47661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ZibinGuo
previously approved these changes
Nov 7, 2022
QingshuChen
reviewed
Nov 7, 2022
| @@ -105,6 +106,8 @@ XPUOpMap& get_kl2_ops() { | |||
| XPUKernelSet({pOpKernelType(vartype::FP32, XPUPlace()), | |||
| pOpKernelType(vartype::FP16, XPUPlace())})}, | |||
| {"clip", XPUKernelSet({pOpKernelType(vartype::FP32, XPUPlace())})}, | |||
| {"clip_by_norm", | |||
There was a problem hiding this comment.
单测之前就有了，不过没有按照目前的格式进行修改。那我修改下重新提交吧。
ZibinGuo
reviewed
Nov 8, 2022
| def test_check_output(self): | ||
| self.check_output() | ||
|
|
||
| class TestAdadeltaOp2(OpTest): |
There was a problem hiding this comment.
目前单测可以跑过，下次pr的时候再修改一下。
ZibinGuo
approved these changes
Nov 8, 2022
houj04
approved these changes
Nov 8, 2022
|
你的PR已合入Paddle库，请关注后续测试结果。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
1、add adadelta op for xpu
2、xpu2_op_list.h增加clip_by_norm声明