Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace shared_ptr with unique_ptr in base_ptr_test #38530

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Replace shared_ptr with unique_ptr in base_ptr_test #38530

merged 1 commit into from
Dec 30, 2021

Conversation

From00
Copy link
Contributor

@From00 From00 commented Dec 28, 2021 •
edited
Loading

PR types

Performance optimization

PR changes

Others

Describe

PR #37978 use more shared_ptr than necessary in base_ptr_test.cu. For performance considering, this PR replaces them with unique_ptr.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhangbo9674
zhangbo9674 approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhangbo9674 zhangbo9674 merged commit 3f6229c into PaddlePaddle:develop Dec 30, 2021
@From00 From00 deleted the replace-shared_ptr-with-unique_ptr-in-base_ptr_test branch December 30, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

@Shixiaowei02 Shixiaowei02 Shixiaowei02 approved these changes

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@From00 @zhiqiu @Shixiaowei02 @zhangbo9674