-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get base pointer from Allocation #37978
Merged
zhiqiu
merged 8 commits into
PaddlePaddle:develop
from
From00:get-cuda-allocation-baseptr
Dec 17, 2021
Merged
Get base pointer from Allocation #37978
zhiqiu
merged 8 commits into
PaddlePaddle:develop
from
From00:get-cuda-allocation-baseptr
Dec 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
zhiqiu
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
For performance considering, Paddle caches and manages the memory malloced from devices. The memory pointer given to user is not the base-pointer that directly returned from the device interface, as it may have undergone many transformations such as split and align by Allocator.
However, sometimes the base-pointer is required. For example, cudaIpcGetMemHandle needs a base-pointer of the device allocation created with cudaMalloc, so it can achieve memory sharing between different processes.
This PR maintains the base-pointer information in all allocators existing in Paddle, and implement a base_ptr interface in Allocation class. Thereby we can get the base-pointer from an allocation like: