Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0API]Add adaptive_avg_pool_2/3d #26369

Merged
merged 13 commits into from
Aug 21, 2020
Merged

[2.0API]Add adaptive_avg_pool_2/3d #26369

merged 13 commits into from
Aug 21, 2020

Conversation

baiyfbupt
Copy link
Contributor

@baiyfbupt baiyfbupt commented Aug 17, 2020 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

Add:

  • paddle.nn.functional.adaptive_avg_pool2d
  • paddle.nn.functional.adaptive_avg_pool3d
  • paddle.nn.AdaptiveAvgPool2d
  • paddle.nn.AdaptiveAvgPool3d

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

WuHaobo
WuHaobo previously approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@WuHaobo WuHaobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baiyfbupt
Copy link
Contributor Author

image
image
image

@baiyfbupt
Copy link
Contributor Author

image
image
image

@baiyfbupt
Copy link
Contributor Author

image
image

@baiyfbupt
Copy link
Contributor Author

image
image

@baiyfbupt baiyfbupt mentioned this pull request Aug 18, 2020
Merged
shippingwang
shippingwang reviewed Aug 20, 2020
View reviewed changes
Copy link
Member

@shippingwang shippingwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some suggestion, feel free to refine them in the next PR or some new rules be pinned now

python/paddle/nn/functional/pooling.py Show resolved Hide resolved
python/paddle/nn/layer/pooling.py Show resolved Hide resolved
python/paddle/nn/functional/pooling.py Show resolved Hide resolved
python/paddle/nn/layer/pooling.py Show resolved Hide resolved
shippingwang
shippingwang approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@shippingwang shippingwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@baiyfbupt baiyfbupt changed the title Add adaptive_avg_pool_2/3d [2.0API]Add adaptive_avg_pool_2/3d Aug 21, 2020
@baiyfbupt baiyfbupt merged commit 74836ec into PaddlePaddle:develop Aug 21, 2020
@shippingwang shippingwang mentioned this pull request Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shippingwang shippingwang shippingwang approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@WuHaobo WuHaobo WuHaobo left review comments

@wanghaoshuang wanghaoshuang Awaiting requested review from wanghaoshuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baiyfbupt @shippingwang @WuHaobo @raindrops2sea