Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

重构paddle/math/tests/ #695

Closed
hedaoyuan opened this issue Dec 1, 2016 · 1 comment
Closed

重构paddle/math/tests/ #695

hedaoyuan opened this issue Dec 1, 2016 · 1 comment
Assignees

Comments

@hedaoyuan
Copy link
Contributor

math/tests里面主要包含对Paddle的一些基本算法实现的测试,但是当前构造tests的自由度比较高,基本可以任意书写test case,这导致代码有很多冗余 #385 ,并且导致很多test case阅读起来也比较困难。tests模块的重构是math模块重构的一部分。

重构主要解决的问题:

  1. 定义tests case的书写方式,在issue Making it easier to write unittest for comparing gpu and cpu version of a function  #385 和pr Auto compare cpu and gpu function. #643 中引入了AutoCompare,能够基本以一种固定的格式来书写test case;
  2. test_matrixCompare.cpp中的test case根据被测试的类型对象分到test_BaseMatrix.cpp, test_Matrix.cpptest_Vector.cpptest_SparseMatrix.cpp等不同文件中;
  3. test_matrixCompare.cpp中不能被AutoCompare覆盖的test case,需定义一个新的统一的方式来书写test case,或者有些是需要修改源码实现的。
@hedaoyuan
Copy link
Contributor Author

对于第3点,后续Matrix中的API会移到Function中,test case也是按照FunctionCompare来写。

zhhsplendid pushed a commit to zhhsplendid/Paddle that referenced this issue Sep 25, 2019
…ePaddle#695)

* Fix arguments according to 1.3 en + ceil,floor trans +operator trans

* fix LoDTensorArray spell
lizexu123 pushed a commit to lizexu123/Paddle that referenced this issue Feb 23, 2024
* update the doc of dygraph qat, test=develop, test=document_fix

* up, test=develop, test=document_fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants