Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

重构class Matrix里面的一些计算API #703

Closed
hedaoyuan opened this issue Dec 2, 2016 · 5 comments
Closed

重构class Matrix里面的一些计算API #703

hedaoyuan opened this issue Dec 2, 2016 · 5 comments
Assignees
@tianbingsz

Comments

@hedaoyuan
Copy link
Contributor

hedaoyuan commented Dec 2, 2016 •
edited
Loading

class Matrix里面的一些计算API的参数是通过shared_ptr来传递，这个看起并没什么必要。MatrixPtr应该是Matrix的一个wrapper，但Matrix自身并不需要用这个wrapper。
可以将这些API的参数修改成传递引用的方式，并且将test_matrixCompare.cpp里面的测试挪到test_Matrix.cpp里面（参考issue #695 和pr #643 ）。
大致看了一下这些API是可以修改的，
contextProjectionForward
contextProjectionBackward
contextProjectionBackwardData
contextProjectionBackwardWeight
classificationError
mul
@backyes
Copy link
Contributor

backyes commented Dec 2, 2016

warp -> wrapper? 这里是包装的意思么？

@hedaoyuan
Copy link
Contributor Author

是的，已经fix

@hedaoyuan hedaoyuan mentioned this issue Dec 13, 2016
Closed
8 tasks
@hedaoyuan
Copy link
Contributor Author

通过Function #892 的形式，重构这些API。

@tianbingsz
Copy link
Contributor

Please refer to #934

@tianbingsz tianbingsz mentioned this issue Dec 20, 2016
Merged
@hedaoyuan
Copy link
Contributor Author

Close this issue by #977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tianbingsz tianbingsz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@backyes @hedaoyuan @tianbingsz