修改转换规则 Nanquantile. #327
Closed
修改转换规则 Nanquantile. #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhwesky2010
reviewed
Nov 6, 2023
| else: | ||
| new_kwargs[k] = kwargs[k] | ||
| if "q" in k: | ||
| if "tensor" in kwargs[k] and "[" in kwargs[k]: |
There was a problem hiding this comment.
这个目前没有很好的方式来转写，因为如果传入的q是一个变量，则无法知道是torch.tensor还是list类型
There was a problem hiding this comment.
是因为转换成了字符串处理吗？我是参考了这个 Matcher 实现的，请问这个变量是元组的话能否转写呢？那这个函数就只修改文档转写然后这里先搁置吗？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
PR APIs
#112
对应文档
添加了 Tensor转化成List的规则。