cmake: use python 3 as default #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see, that all docker build environment images must also be changed to have the python packages like jinja2 installed with pip3. Same issue with macOS, that is handled in the travis configuration directly. |
|
@jbeyerstedt I superseded this PR in #373. Is it fine with you I close this and we bring the change in the other PR? |
|
Your PR looks way better than mine, so I'll close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you all know, the end of python 2 comes closer and closer. Even if the python3 support for PX4 is still under construction (see PX4/PX4-Autopilot#12809 and PX4/PX4-Autopilot#13008), using python3 here might be easier to achieve?
Another solution would be to replace
find_package(PythonInterp REQUIRED)withfind_package(Python REQUIRED)in theCMakeLists.txt, becauseFindPythonInterpgot deprecated and replaced byFindPythonwith cmake 3.12. (This change also renamedPYTHON_EXECUTABLEtoPython_EXECUTABLE.)But only Ubuntu 18.10 „Cosmic Cuttlefish“ or Debian Buster come with the needed cmake version and the PX4 docs still support and even recommend ubuntu 16.04. So this change might be a bit early.