Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune shakey typhoon_h480 gimbal #355

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Tune shakey typhoon_h480 gimbal #355

merged 1 commit into from
Oct 16, 2019

Conversation

Jaeyoung-Lim
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim commented Oct 15, 2019

This PR tunes the gain of the gimbal controller so that it is less shakey on the yaw axis. The previous state was not usable to run any survey missions in SITL.

The change is visually observable as the following example where the vehicle is flown in position mode in SITL

After PR:
after_change

Before PR:
before_change

@bkueng
Copy link
Member

bkueng commented Oct 16, 2019

Did you test with more aggressive maneuvers and other directions as well?

@Jaeyoung-Lim
Copy link
Member Author

Jaeyoung-Lim commented Oct 16, 2019

@bkueng More or less yes, I tried flying quite aggressively in position mode and also yawing. The main testing was to reduce the shaking of the camera in mission mode and it looks much better. I have also tested for the case when the gimbal is looking down

I tried to find a way to log the vmount orientation in to the flight log but couldn't find any. Would you have any pointers?

@bkueng
Copy link
Member

bkueng commented Oct 16, 2019

@bkueng More or less yes, I tried flying quite aggressively in position mode and also yawing. The main testing was to reduce the shaking of the camera in mission mode and it looks much better. I have also tested for the case when the gimbal is looking down

You can test in Altitude/Manual.

I tried to find a way to log the vmount orientation in to the flight log but couldn't find any. Would you have any pointers?

We don't get that feedback if I remember correctly.

Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@TSC21 TSC21 merged commit 77286eb into master Oct 16, 2019
@TSC21 TSC21 deleted the pr-fix-h480-gimbal branch October 16, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants