[DO NOT MERGE] Nxphlite temporary fixes #9504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realize this is just a testing PR, but for some background dataman needs to be running before command and mavlink to reinit an existing mission. |
dagar
changed the title
davids5
reviewed
Jun 21, 2018
| @@ -989,7 +989,7 @@ HMC5883::collect() | |||
| sensor_is_onboard = !_interface->ioctl(MAGIOCGEXTERNAL, dummy); | |||
| new_report.is_external = !sensor_is_onboard; | |||
|
|
|||
| #ifdef PX4_I2C_BUS_ONBOARD_EXP | |||
| #ifdef CONFIG_ARCH_BOARD_NXPHLITE_V3 | |||
There was a problem hiding this comment.
@DanielePettenuzzo I know this is a DNM HACK but just for the record we alway avoid any CONFIG_ARCH_BOARD_xxxx in common code. The thinking is name it as a feature and if def on that. See
|
This should all be fixed in #9392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!
Hack to fix mag and dataman issue on nxphlite. First of all the hmc5883 driver was not started in the rc.sensors. Second, this mag is on an I2C bus that is defined as internal in the board config. With this modification it will be forced to be set as external.
Dataman works if started at the end of the rCS. Further investigation is required to understand what is the cause of this. This fix allows to upload/download missions from sd card.