Failsafe params update to reflect current mode names #9429
Conversation
| * @value 5 Loiter | ||
| * @value 0 Position mode | ||
| * @value 1 Altitude mode | ||
| * @value 2 Manual/Stabilized |
There was a problem hiding this comment.
This needs to be checked. I believe that this should be Manual-Stabilized mode in MC and Stabilized mode in FW (rather than Manual mode in FW, which would not be a sensible mode switch).
There was a problem hiding this comment.
It actually goes into Manual, even in fixed-wing. Not sure if that's intended though.
There was a problem hiding this comment.
So Manual for both cases (where MC Manual is actually Manual/Stabilized) I will change appropriately.
The manual is very hard to fly apparently in FW. Would have thought Stabilized made more sense for FW.
src/modules/navigator/rtl_params.c
Outdated
| @@ -53,13 +53,13 @@ | |||
| * @max 150 | |||
| * @decimal 1 | |||
| * @increment 0.5 | |||
| * @group Return To Land | |||
| * @group Return mode | |||
There was a problem hiding this comment.
@bkueng Note I changed the group here (and below)- hope this is OK!
There was a problem hiding this comment.
I'm ok with that. Can you capitalize Mode?
|
Should be good to merge now. |
Discussed with @bkueng in PX4/PX4-user_guide#212 (comment)