-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr aero battery initialization hotfix #8940
Conversation
On the Intel Aero and probably also other specific platforms the first measured voltage values despite connected battery are unuasable. The solution here is to start filtering and determining warning only after a measurement above 2.1V was received.
@santiago3dr Can you please also test this on the platforms that you had issues with battery estimation? |
@MaEtUgR Please assign @PX4/testflights as reviewer for things that need on-HW testing. @PX4/testflights please make sure this doesn't break any other config that you fly. Please test different vehicles. |
Flight with pixhawk 1- V2. No issues. Flight with pixhawk Pro - V4pro. No issues. |
pixracer (v4): snapdragon (eagle): all features working as expected; no notable difference from master aerotenna (OcPoc): looks to have resolved issue #8932 |
pixhawk mini v3.- the battery sensor worked very well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR performed well on other platforms than the aero, we couldn't test it in the aero due to connection issues, but @MaEtUgR tested it (bench testing).
On the Intel Aero and probably also other specific platforms the first measured voltage values despite connected battery are unuasable. The solution here is to start filtering and determining warning only after a measurement above 2.1V was received. This condition was anyways used before to determine if the battery status report gets filled at all.
I bench tested this on an Intel Aero. Can someone else please also confirm?
fixes #8930